Skip to content

Block splitting - Handle the case when the split occurs at the trailing or leading edge#176

Merged
diegoreymendez merged 1 commit intomasterfrom
split-occurs-at-trailing-or-leading-edge
Oct 18, 2018
Merged

Block splitting - Handle the case when the split occurs at the trailing or leading edge#176
diegoreymendez merged 1 commit intomasterfrom
split-occurs-at-trailing-or-leading-edge

Conversation

@daniloercoli
Copy link
Copy Markdown
Contributor

This PR adds handles the case when the split occurs at the trailing or leading edge of the field.

Testing:

  1. Put the cursor at the end of a para block and hit enter. It should add an empty block after the current.
  2. Put the cursor at the end of a para block and hit Enter. It should add a block after the current with all the content. Current block will be blank after.
  3. Put the cursor in the middle of a block, and hit Enter.

Note: there are some known issues with Heading blocks and validation. Will address that in another PR.

Companion PR:

Copy link
Copy Markdown
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Awesome work!

Two notes:

  • As mentioned by @daniloercoli, the heading blocks have some validation issues when switching to HTML and back.
  • The heading blocks don't work very well when splitting.
  • Blocks are not properly resized when split.

@diegoreymendez diegoreymendez merged commit abe118a into master Oct 18, 2018
@diegoreymendez diegoreymendez deleted the split-occurs-at-trailing-or-leading-edge branch October 18, 2018 15:14
@diegoreymendez
Copy link
Copy Markdown
Contributor

Related to #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants