Fix app crash after block removal due to undo button pressing#1701
Merged
Fix app crash after block removal due to undo button pressing#1701
undo button pressing#1701Conversation
6 tasks
geriux
approved these changes
Dec 19, 2019
Contributor
geriux
left a comment
There was a problem hiding this comment.
Looks good! Tested it via WordPress/gutenberg#19239 (review)
Can you please reference the other issue in this PR as well? So we can keep track of it after we release this.
…e into fix-undo-crash
This was referenced Jan 8, 2020
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1699 & wordpress-mobile/WordPress-Android#10876
Ref to gutenberg repo: WordPress/gutenberg#19239
To test:
1.Open mobile app
2. Add a block
3.Press undo button
4. Add a new block - if app not crashing everything is good 👍
PR submission checklist:
RELEASE-NOTES.txtif necessary.