Skip to content

Fix focus loop when autocompleting text on iOS#1698

Closed
koke wants to merge 1 commit intodevelopfrom
fix/rich-text-autocomplete-focus-loop
Closed

Fix focus loop when autocompleting text on iOS#1698
koke wants to merge 1 commit intodevelopfrom
fix/rich-text-autocomplete-focus-loop

Conversation

@koke
Copy link
Copy Markdown
Member

@koke koke commented Dec 19, 2019

See WordPress/gutenberg#19234
Fixes #1696

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@koke koke added the [Type] Bug Something isn't working label Dec 19, 2019
@koke koke added this to the 1.20 milestone Dec 19, 2019
@koke koke requested a review from pinarol December 19, 2019 08:55
@koke koke mentioned this pull request Dec 19, 2019
Closed
6 tasks
@mchowning mchowning mentioned this pull request Dec 19, 2019
Merged
2 tasks
@mchowning
Copy link
Copy Markdown
Contributor

mchowning commented Dec 19, 2019

Do we have two PRs addressing the same issue? cc: @dratwas

#1702

@etoledom etoledom modified the milestones: 1.20, 1.22 Jan 20, 2020
@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Jan 20, 2020

Moved milestone to v1.22.
Please feel free to re-target if you consider this PR must be shipped together with v1.21.

@koke
Copy link
Copy Markdown
Member Author

koke commented Jan 23, 2020

This was fixed in #1702

@koke koke closed this Jan 23, 2020
@koke koke deleted the fix/rich-text-autocomplete-focus-loop branch January 23, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol Awaiting requested review from pinarol

Assignees

No one assigned

Labels

[Type] Bug Something isn't working

Projects

None yet

Milestone

1.22

Development

Successfully merging this pull request may close these issues.

Focus loop on Rich Text

3 participants

@koke @mchowning @etoledom