Skip to content

Incorporate fixes to some recent regressions#1690

Closed
hypest wants to merge 1 commit intodevelopfrom
incorporate-gb-web-fixes
Closed

Incorporate fixes to some recent regressions#1690
hypest wants to merge 1 commit intodevelopfrom
incorporate-gb-web-fixes

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Dec 17, 2019 •
edited
Loading

Update Gutenberg ref to incorporate fixes to some recent regressions

Fixes included for the following regressions:

  1. Paste: apply active formats when pasting inline WordPress/gutenberg#14815 (comment) (Gutenberg PR)
  2. Convert to blocks: preserve alignment WordPress/gutenberg#19097 (comment) (Gutenberg PR)

To test:

CI should be green.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest mentioned this pull request Dec 17, 2019
Merged
6 tasks
@ellatrix
Copy link
Copy Markdown
Collaborator

ellatrix commented Dec 17, 2019

Is there any way these tests can be run for Gutenberg?

@ellatrix
Copy link
Copy Markdown
Collaborator

ellatrix commented Dec 17, 2019

Asking because, even if native files were updated, there's no way to know for sure if everything works correctly.

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Dec 18, 2019

👋 @ellatrix , assuming you mean running them in the Gutenberg repo, I guess we are not there yet, but we are heading that way, to incorporate native mobile e2e tests into the Gutenberg repo.

In the meantime, may I take this opportunity to suggest that, it would be useful if at least for changes in the RichText components you open PRs here in the mobile repo to test and merge? To do so, It basically boils down to updating the Gutenberg git submodule to point to the desired Gutenberg commit and push a branch and PR it. Happy to elaborate more if needed. WDYT?

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Dec 18, 2019

This PR is not needed anymore since the latest from Gutenberg was brought in by #1631.

@hypest hypest closed this Dec 18, 2019
@hypest hypest deleted the incorporate-gb-web-fixes branch December 18, 2019 08:56
@ellatrix
Copy link
Copy Markdown
Collaborator

ellatrix commented Dec 21, 2019

@hypest Sure, would love to do it for the bigger rich text PRs. Looking forward to have those tests in the main repo though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hypest @ellatrix