Image block: Hide Size options when Image object is undefined#1669
Merged
Image block: Hide Size options when Image object is undefined#1669
Conversation
…ize-option-conditionally
8 tasks
54b8fe2 to
d845357
Compare
mchowning
approved these changes
Dec 18, 2019
This was referenced Jan 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes point 3 of #1593
gutenbergside PR: WordPress/gutenberg#19037When the image object is not present, the Image Size option won't be present in the Image Options.
The Image object is fetched on a network call for images stored in the WP Media Library. For images added via link, this object is never fetched.
Other cause of the object being missing is network call errors.
With this change we are looking to avoid the case when the ImageSize is displayed in the UI, but it does nothing.
Test:
Update release notes:
RELEASE-NOTES.txt.