Skip to content

Fix broken link in Getting Started documentation#1666

Merged
hypest merged 1 commit intodevelopfrom
update/fix-broken-link
Jan 24, 2020
Merged

Fix broken link in Getting Started documentation#1666
hypest merged 1 commit intodevelopfrom
update/fix-broken-link

Conversation

@designsimply
Copy link
Copy Markdown
Contributor

Update the example unit test link to something not broken.

I picked develop/src/index.test.js after finding it in a quick search, but let me know if there's a better one to link to!

To test: review README.md.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Update the example unit test link to something not broken.

I picked `develop/src/index.test.js` after finding it in a quick search, but let me know if there's a better one to link to!
Copy link
Copy Markdown
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests at /src/index.test.js are the same tests that were previously in /src/app/App.test.js so this looks like a good change to me. :shipit:

(Also just want to note I'm aware the Android UI tests are failing in this PR. This PR only has documentation changes so it's fine but if this is a common issue we need to investigate why those failures are happening.)

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Jan 24, 2020

I think the PR needs an update from develop to make the tests pass. But, the changes here are totally not code related so, I'll go ahead and merge them since the PR is otherwise 👍'd. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants