Skip to content

Image block Caption.#161

Merged
etoledom merged 4 commits intomasterfrom
feature/image-caption
Oct 17, 2018
Merged

Image block Caption.#161
etoledom merged 4 commits intomasterfrom
feature/image-caption

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Oct 15, 2018

Part of #140

This PR implements the changes on the main gutenberg repo to show the image caption on the image block.

caption

To test:

  • Checkout and update Gutenberg.
  • Run the project.
  • Check that the caption is visible.
  • Check that you can edit and remove the caption.
  • Check that the changes are visible on the HTML view.

@etoledom etoledom self-assigned this Oct 15, 2018
@etoledom etoledom requested a review from hypest October 15, 2018 13:33
@etoledom etoledom mentioned this pull request Oct 15, 2018
Closed
@etoledom etoledom merged commit fbdd8af into master Oct 17, 2018
@etoledom etoledom deleted the feature/image-caption branch October 17, 2018 11:55
@etoledom etoledom mentioned this pull request Oct 17, 2018
Closed
10 tasks
@koke koke mentioned this pull request Oct 17, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hypest hypest Awaiting requested review from hypest

Assignees

@etoledom etoledom

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@etoledom