Skip to content

Image Size improvements Mark I#1598

Merged
etoledom merged 5 commits intodevelopfrom
issue/image-size-improvements-mark-i
Nov 22, 2019
Merged

Image Size improvements Mark I#1598
etoledom merged 5 commits intodevelopfrom
issue/image-size-improvements-mark-i

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Nov 20, 2019

This PR updates the gutenberg ref to test WordPress/gutenberg#18627

Fixes 4 and 5 from #1593

More info in the gutenberg side PR: WordPress/gutenberg#18627

To test:

  • On WPiOS or WPAndroid.
  • Set a new Image block.
  • Set add an image to the block (any source should work).
  • Switch to HTML mode.
    • IF WPCom: Check that the image URL has the ?w=xxx property.
    • IF Self-Hosted: Check that the image URL is the proper resized variant: ...img_2782-768x1024.jpg or similar.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added this to the 1.18 milestone Nov 20, 2019
@etoledom etoledom requested a review from mchowning November 20, 2019 10:18
@etoledom etoledom self-assigned this Nov 20, 2019
This was referenced Nov 20, 2019
Merged
Closed
@etoledom etoledom merged commit f44b4d7 into develop Nov 22, 2019
@etoledom etoledom deleted the issue/image-size-improvements-mark-i branch November 22, 2019 09:53
@maxme maxme mentioned this pull request Nov 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mchowning mchowning mchowning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@etoledom etoledom

Labels

bugfix

Projects

None yet

Milestone

1.18

Development

Successfully merging this pull request may close these issues.

2 participants

@etoledom @mchowning