Skip to content

Undo more changes related to PRE support#1578

Merged
hypest merged 2 commits intorelease/1.17from
try/remove-android-side-from-pre
Nov 14, 2019
Merged

Undo more changes related to PRE support#1578
hypest merged 2 commits intorelease/1.17from
try/remove-android-side-from-pre

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Nov 14, 2019 •
edited
Loading

Undos more Android side changes introduced when we merged #1442 into the v1.17 release branch. Apparently, a crash is happening without this PR:

E/SoLoader: couldn't find DSO to load: libreactnativejni.so
...
    --------- beginning of crash
2019-11-14 11:34:24.902 5647-6174/org.wordpress.android.beta E/AndroidRuntime: FATAL EXCEPTION: create_react_context
    Process: org.wordpress.android.beta, PID: 5647
    java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libreactnativejni.so
        at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java:738)
        at com.facebook.soloader.SoLoader.loadLibraryBySoName(SoLoader.java:591)
        at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:529)
        at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:484)
        at com.facebook.react.bridge.ReactBridge.staticInit(ReactBridge.java:31)
        at com.facebook.react.bridge.NativeMap.<clinit>(NativeMap.java:19)
        at com.facebook.react.jscexecutor.JSCExecutorFactory.create(JSCExecutorFactory.java:25)
        at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:949)
        at java.lang.Thread.run(Thread.java:764)

Note: @hypest could see the crash but @daniloercoli couldn't reproduce.

For code review:

  1. See this diff versus the release branch (this PR versus the release hash right before the PRE merge): a680244...try/remove-android-side-from-pre
  2. There should be no Android side changes since the Preformatted feature only lands for iOS in this release

To test:

  1. Use the WPAndroid side release v1.17 PR to test this and point the gutenberg-mobile submodule to this PR
  2. Open a Gutenberg post
  3. The editor should open normally

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest added this to the 1.17 milestone Nov 14, 2019
@hypest hypest requested a review from SergioEstevao November 14, 2019 09:45
SergioEstevao
SergioEstevao approved these changes Nov 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my Android device and the posts open correctly and I'm able to edit content.

@hypest hypest mentioned this pull request Nov 14, 2019
Closed
2 tasks
@hypest hypest merged commit e2b1b0b into release/1.17 Nov 14, 2019
@hypest hypest deleted the try/remove-android-side-from-pre branch November 14, 2019 11:39
@hypest hypest mentioned this pull request Nov 14, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

No one assigned

Labels

bugfix [OS] Android

Projects

None yet

Milestone

1.17

Development

Successfully merging this pull request may close these issues.

2 participants

@hypest @SergioEstevao