Skip to content

Force block inserter to re-render on device rotation#1495

Merged
etoledom merged 3 commits intorelease/1.15.2from
issue/fix-block-picker-landscape
Oct 25, 2019
Merged

Force block inserter to re-render on device rotation#1495
etoledom merged 3 commits intorelease/1.15.2from
issue/fix-block-picker-landscape

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Oct 25, 2019

This PR uses onLayout and the internal State of inserter menu to force a re-render of the component on device rotation.

gutenberg PR: WordPress/gutenberg#18101

Fixes: #1491

  • Run the example app (iOS and Android).
  • Press (+) to show the block inserter.
  • Check that the layout looks fine.
  • Rotate the device.
  • Check that the layout rearranges.

Note: There's a small jump after the rotation while the layout changes. As a hotfix is probably good enough, but I'd like to check this out later on.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added this to the 1.15 milestone Oct 25, 2019
@etoledom etoledom requested a review from pinarol October 25, 2019 08:30
@etoledom etoledom self-assigned this Oct 25, 2019
@etoledom etoledom mentioned this pull request Oct 25, 2019
Merged
@etoledom etoledom marked this pull request as ready for review October 25, 2019 08:52
@hypest
Copy link
Copy Markdown
Contributor

hypest commented Oct 25, 2019

Tested on few of my android devices:

Tests:

  1. Open Inserter in portrait and rotate. Make sure the Inserter still looks OK in landscape. Rotate back to portrait, make sure it still looks OK.
  2. Open Inserter in landscape and rotate. Make sure it looks OK. Rotate back and should still look OK.

Device:

  1. Nexus 5X (Android 7.1.2): all tests OK ✅
  2. Samsung Galaxy S7E Android 8.0.0): all tests OK ✅
  3. Pixel 2 XL (Android 9): all tests OK ✅

pinarol
pinarol approved these changes Oct 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 🎉 Thanks @etoledom for the PR!
Before this change I was able to reproduce the problem on iPhone 8. With this PR the problem is fixed. BottomSheet refreshes its layout when I rotate the device.

Tested with WordPress-iOS app

@etoledom etoledom merged commit 2abde85 into release/1.15.2 Oct 25, 2019
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Oct 25, 2019

Thank you! 🙏

@etoledom etoledom deleted the issue/fix-block-picker-landscape branch October 25, 2019 11:11
@etoledom etoledom modified the milestones: 1.15, 1.15.2 Oct 28, 2019
This was referenced Oct 28, 2019
Merged
Merged
Merged
@designsimply designsimply mentioned this pull request Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

@etoledom etoledom

Labels

bugfix

Projects

None yet

Milestone

1.15.2

Development

Successfully merging this pull request may close these issues.

3 participants

@etoledom @hypest @pinarol