Skip to content

iOS dark mode improvements#1415

Merged
etoledom merged 5 commits intodevelopfrom
issue/1391-ios-dark-mode-issues
Oct 9, 2019
Merged

iOS dark mode improvements#1415
etoledom merged 5 commits intodevelopfrom
issue/1391-ios-dark-mode-issues

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Oct 7, 2019

Fixes #1391 by the changes on WordPress/gutenberg#17802

This PR also fixes another DarkMode issue I found while testing this:

  • Typing attributes won't update appropriately when textColor changes.

dark-mode-issue

To test:

  • Checkout gutenberg-mobile PR: TBD
  • Run the project on iOS 13 with dark mode.
  • Add a List block.
  • Check that the placeholder is properly lied out.
    --
  • Switch to light mode.
  • Create a new List block.
  • Write some text on it.
  • Switch to dark mode.
  • Delete the text and write new text.
  • Check that the text color is white.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added [Type] Enhancement Improves a current area of the editor Dark mode labels Oct 7, 2019
@etoledom etoledom added this to the 1.15 milestone Oct 7, 2019
@etoledom etoledom requested a review from SergioEstevao October 7, 2019 10:12
@etoledom etoledom self-assigned this Oct 7, 2019
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this fix!

@etoledom etoledom merged commit a2623b9 into develop Oct 9, 2019
@etoledom etoledom deleted the issue/1391-ios-dark-mode-issues branch October 9, 2019 06:25
@phillipcornwell
Copy link
Copy Markdown

Testing Environment:
iOS 13.1.3
iPhone 7 Plus

Results:
This works well for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dark mode [Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] List block: Bullet overlaps placeholder in dark mode

3 participants