Skip to content

Add FloatingToolbar component#1362

Merged
pinarol merged 12 commits intodevelopfrom
callstack/rnmobile/floating-toolbar
Oct 3, 2019
Merged

Add FloatingToolbar component#1362
pinarol merged 12 commits intodevelopfrom
callstack/rnmobile/floating-toolbar

Conversation

@lukewalczak
Copy link
Copy Markdown
Contributor

@lukewalczak lukewalczak commented Sep 10, 2019

Fixes #1317

To test:

Tested on both platforms
WordPress/gutenberg#17399

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Oct 1, 2019

Can we add a check to make FloatingToolbar visible only on Group block for now? Otherwise it can be a blocker to ship Media & Text block.

@lukewalczak
Copy link
Copy Markdown
Contributor Author

@pinarol I've changed it within PR

Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@pinarol pinarol merged commit 70061b2 into develop Oct 3, 2019
@pinarol pinarol deleted the callstack/rnmobile/floating-toolbar branch October 3, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inner Blocks - Floating Toolbar

2 participants