Skip to content

Move MediaUploadPorgress to its own component folder#1361

Merged
koke merged 7 commits intodevelopfrom
feature/move-media-upload-progress
Sep 27, 2019
Merged

Move MediaUploadPorgress to its own component folder#1361
koke merged 7 commits intodevelopfrom
feature/move-media-upload-progress

Conversation

@geriux
Copy link
Copy Markdown
Contributor

@geriux geriux commented Sep 9, 2019

Gutenberg PR WordPress/gutenberg#17392

Description

This small PR moves MediaUploadProgress out of image (native) to its own component folder. In favor of #1313 to be able to reuse this for the Media & Text block.

To test it:

  • Add an image block and check it works as expected: upload bar, placeholder.
  • Add a video block and check it works as expected: upload bar, placeholder.

@geriux geriux requested a review from koke September 23, 2019 19:36
@geriux
Copy link
Copy Markdown
Contributor Author

geriux commented Sep 27, 2019

@koke ready to be reviewed =)

@koke koke merged commit c364ab4 into develop Sep 27, 2019
@pinarol pinarol added this to the 1.14 milestone Oct 2, 2019
@pinarol pinarol added the Media label Oct 2, 2019
@geriux geriux deleted the feature/move-media-upload-progress branch October 2, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants