Skip to content

Fix MaxListenersExceededWarning caused by dark-mode event emitter#1325

Merged
etoledom merged 7 commits intorelease/1.11.0from
issue/fix-max-events-warning
Aug 26, 2019
Merged

Fix MaxListenersExceededWarning caused by dark-mode event emitter#1325
etoledom merged 7 commits intorelease/1.11.0from
issue/fix-max-events-warning

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

This PR fixes a warning caused by RNDarkMode event emitter:

gutenberg PR: WordPress/gutenberg#17186

axListenersExceededWarning: Possible EventEmitter memory leak detected. 11 currentModeChanged listeners added. Use emitter.setMaxListeners() to increase limit

To test:

  • Run the demo app.
  • Check that the warning does not appear.

@etoledom etoledom requested a review from Tug August 26, 2019 08:13
name: Restore Yarn Cache
keys:
- yarn-i18n-v3-{{ .Environment.CIRCLE_JOB }}-{{ checksum "yarn.lock" }}
- yarn-i18n-v4-{{ .Environment.CIRCLE_JOB }}-{{ checksum "yarn.lock" }}
Copy link
Copy Markdown
Contributor Author

@etoledom etoledom Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to fix the UI Test CI failing by clearing cache but it didn't work.
Now that the cache folder was created, not sure if we should roll it back.

Copy link
Copy Markdown
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etoledom etoledom mentioned this pull request Aug 26, 2019
11 tasks
@etoledom etoledom merged commit 64ac513 into release/1.11.0 Aug 26, 2019
@etoledom etoledom deleted the issue/fix-max-events-warning branch August 26, 2019 11:11
@etoledom
Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants