Merged
Conversation
Changed for a custom Theme HOC
mchowning
approved these changes
Aug 23, 2019
Contributor
mchowning
left a comment
There was a problem hiding this comment.
LGTM! Tested via gutenberg#17067.
Contributor
Author
|
Thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary changes to implement DarkMode on iOS.
Gutenberg PR: WordPress/gutenberg#17067
Prerequisites to test:
open ios/gutenberg.xcodeprojyarn clean:installto install the new dependencyTo test:
Note:
The toolbar buttons are not yet updated. I believe that the IconButon component will need a deeper refactor to be able to select different colors on all its states.
For some reason, some components won't change of color mode dynamically (bottom-sheet, some elements in the tool bar). I'll investigate this and try to update. But I think this fix can be added as a future PR.
The horizontal SafeArea is gray, and that's not great. My first try to fix this broke the tool bar avoiding view behavior. Same than the previous point, I'll investigate this but can be left for a future PR.
If there are user facing changes, I have added an item to
RELEASE-NOTES.txt.