Skip to content

Prevent always dismissing keyboard when switching away from empty image caption#1245

Merged
mchowning merged 1 commit intodevelopfrom
issue/1221-prevent_keyboard_from_always_dismissing_when_closing_caption
Jul 30, 2019
Merged

Prevent always dismissing keyboard when switching away from empty image caption#1245
mchowning merged 1 commit intodevelopfrom
issue/1221-prevent_keyboard_from_always_dismissing_when_closing_caption

Conversation

@mchowning
Copy link
Copy Markdown
Contributor

Fixes #1221

Detailed description and testing steps are in the related gutenberg PR

There are user facing changes, so I have updated RELEASE-NOTES.txt.

@mchowning mchowning changed the title Prevent always dismissing keyboard when switching away from empty caption Prevent always dismissing keyboard when switching away from empty image caption Jul 25, 2019
@mchowning mchowning self-assigned this Jul 25, 2019
@mchowning mchowning added this to the Open Beta milestone Jul 25, 2019
@mchowning mchowning requested review from Tug and daniloercoli July 25, 2019 20:41
* Deselect post title any time a block is added
* Fix merging of empty paragraph blocks when added from a post's title
* Fix loss of center alignment in image captions
* Prevent keybaord dismissal when switching between caption and text block
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/keybaord/keyboard 😺

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

Thanks for catching that @hypest ! Fixed now.

@mchowning mchowning force-pushed the issue/1221-prevent_keyboard_from_always_dismissing_when_closing_caption branch from b0a30b3 to 5e4e677 Compare July 26, 2019 11:09
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Feel free to merge when the Gutenberg side PR is merged too!

@mchowning mchowning force-pushed the issue/1221-prevent_keyboard_from_always_dismissing_when_closing_caption branch from 5e4e677 to 681cc7c Compare July 30, 2019 14:25
@mchowning mchowning force-pushed the issue/1221-prevent_keyboard_from_always_dismissing_when_closing_caption branch from 681cc7c to be3178e Compare July 30, 2019 21:34
@mchowning
Copy link
Copy Markdown
Contributor Author

I updated this PR to no longer update the README. That will be taken care of in this PR.

@mchowning mchowning merged commit 51ccdb5 into develop Jul 30, 2019
@mchowning mchowning deleted the issue/1221-prevent_keyboard_from_always_dismissing_when_closing_caption branch July 31, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Virtual keyboard dismisses when focus moves from image/video caption to paragraph

2 participants