Conversation
Merged
5 tasks
marecar3
approved these changes
Jul 18, 2019
Contributor
marecar3
left a comment
There was a problem hiding this comment.
Nice work @mchowning ! 🎉
I think that we are good to go with this one!
453de05 to
621a490
Compare
1 task
This was referenced Jul 22, 2019
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #632 : "Add Block Here" (ABH) indicator isn't shown when title field is focused.
Related gutenberg PR
Remaining Issue
The ABH indicator is still not shown when a new post is created and a new block is added before the user has interacted with the post content (i.e. if the user either tries to add a block first thing or only interacts with the post title, then adding a new block will not display the ABH indicator). This is because the ABH indicator is attached to our block holders, but until the user taps on the "Start writing..." placeholder text in a new post, the post does not actually contain any blocks (it just has a
RichTextfield that is replaced with a blockonTouch). This actually may not be a bad thing since in that scenario we replace the entire "Start writing..." text with whatever block is added, but it is inconsistent with how we handle other similar scenarios. Iwill reachhave reached out for some feedback in the issue and will make any needed updates to address this edge case in a separate PR.To Test
Main Functionality
Regression check
Update release notes:
RELEASE-NOTES.txt.