Skip to content

Move BlockManager to gutenberg#1169

Merged
Tug merged 7 commits intodevelopfrom
update/move-block-manager-to-gutenberg
Jun 21, 2019
Merged

Move BlockManager to gutenberg#1169
Tug merged 7 commits intodevelopfrom
update/move-block-manager-to-gutenberg

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented Jun 21, 2019

Step 8 of #958
This is the next step in our port of the BlockList to gutenberg.

Gutenberg PR WordPress/gutenberg#16239

Testing Instructions

  • Boot the app on iOS and Android
  • Check that the block list works as expected.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@Tug Tug added the [Type] Enhancement Improves a current area of the editor label Jun 21, 2019
@Tug Tug added this to the v1.8 milestone Jun 21, 2019
@Tug Tug self-assigned this Jun 21, 2019
@Tug Tug changed the title Update/move block manager to gutenberg Move BlockManager to gutenberg Jun 21, 2019
@koke koke mentioned this pull request Jun 21, 2019
10 tasks
@Tug Tug requested review from SergioEstevao, etoledom and hypest June 21, 2019 14:40
@Tug Tug marked this pull request as ready for review June 21, 2019 15:15
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working ok, the CI Android test failed, but I ran the tests locally and all was ok.

@Tug
Copy link
Copy Markdown
Contributor Author

Tug commented Jun 21, 2019

@SergioEstevao there was an issue on android where switching from the html editor to the visual one would not update the blocks, it's fixed now with 3fdce95 :)

@Tug Tug merged commit 2964e83 into develop Jun 21, 2019
@Tug Tug deleted the update/move-block-manager-to-gutenberg branch June 21, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants