Conversation
…rg-mobile into add/tests-add-block-insertion
…rg-mobile into add/tests-add-block-insertion
There was a problem hiding this comment.
Nice job @JavonDavis ! This looks good!
I made a couple of small comments that are mostly just me trying to learn more about our test setup.
The one important thing I noticed is that the new test for inserting blocks when the title block is selected will break once develop is merged because I recently merged a PR that changes this behavior. Blocks inserted from the title are now inserted at the beginning of the post instead of the end. Once that is fixed, I think this PR will be good to go!
| exports.shortText = `Rock music approaches at high velocity.`; | ||
|
|
||
| exports.mediumText = `The finer continuum interprets the polynomial rabbit. When can the geology cheat? An astronomer runs. Should a communist consent?`; | ||
| exports.mediumText = `The finer continuum interprets the polynomial rabbit. When can the geology runs? An astronomer runs. Should a communist consent?`; |
There was a problem hiding this comment.
Changes here were made to avoid autocomplete causing validation errors.
|
It seems an upgrade to the packages caused the tests to stop running in parallel and the length of the runs went up back to about 30 mins, I made a few additional changes to command revert that. |
…rg-mobile into add/tests-add-block-insertion
|
Hey @JavonDavis ! The code changes look good to me, but the tests are failing to run on CI. Looks like the missing file being referenced was added recently, but neither |
Part of #745
To test: Run
TEST_RN_PLATFORM=android yarn device-tests __device-tests__/gutenberg-editor-block-insertion.test.jsThe PR also updates the filename used for the app to include the branch name as a unique identifier. There's a little concern about branches that might be running at the same time using the same filename and end up testing the wrong versions of the app. This change eliminates that
Update release notes:
RELEASE-NOTES.txt.