Skip to content

Port InlineToolbar to Gutenberg as BlockMobileToolbar#1133

Merged
Tug merged 10 commits intodevelopfrom
update/move-inline-toolbar-to-block-mobile-toolbar
Jun 18, 2019
Merged

Port InlineToolbar to Gutenberg as BlockMobileToolbar#1133
Tug merged 10 commits intodevelopfrom
update/move-inline-toolbar-to-block-mobile-toolbar

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented Jun 14, 2019

Step 4 of #958
This is the next step in our port of the BlockList to gutenberg.

Gutenberg PR WordPress/gutenberg#16177

Testing Instructions

  • Boot the app on iOS and Android
  • Check that the inline toolbar (toolbar that appears under a block when focused) is still functional meaning you can move a block up, down, remove it and access its settings in some cases.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@Tug Tug added the [Type] Enhancement Improves a current area of the editor label Jun 14, 2019
@Tug Tug added this to the v1.8 milestone Jun 14, 2019
@Tug Tug self-assigned this Jun 14, 2019
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @Tug !
Tested via WordPress/gutenberg#16177 (review)

Feel free to :shipit: after updating the gutenberg ref 👍

@Tug Tug merged commit 98e63af into develop Jun 18, 2019
@Tug Tug deleted the update/move-inline-toolbar-to-block-mobile-toolbar branch June 18, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants