Removes empty lines lists and quotes#1129
Conversation
etoledom
left a comment
There was a problem hiding this comment.
Great job @SergioEstevao ! 🎉
List blocks is working great!
I just found a small problem with the Quote block:
The citation is not allowing me to create more than 2 paragraphs.
And I can't delete the second line when it's empty
And also the Image Caption field is not responding to Enter keys anymore.
These fields use \n as line terminator and it's translated to <br> by Aztec, maybe that's the difference.
|
@etoledom Thanks for the review! I updated some of the code to take account the I think the issues are now sorted, can you give it another go? |
etoledom
left a comment
There was a problem hiding this comment.
Thank you for the update @SergioEstevao !
Both Quote and List block already feel so much nicer 🎉
The previous issue is completely fixed.
There is still an extra empty line on the cite field inside the Quote block that is traduced to an extra <br> tag at the end of the cite.
The gif shows two issues related to this:
- After pressing enter once, I can't delete the new line.
- After removing the extra new line at the bottom, pressing enter generates it again but the cursor stays at the same position.
I'm happy to ✅ if you think this is better suited for another PR, since the main problem is already fixed.
I thought I found another issue on List blocks, but then I realized that this is also happening on web. (I could reproduce it on https://frontenberg.tomjn.com)
The issue happens when merging into a list with many indented items: After merging, all the indented items will merge into one. It sounds familiar so we might have seen something similar before. I'm just writing it down in case you or someone else sees it.
|
@etoledom the cite problem you are still seeing it's because Aztec auto adds If we you are happy to approve now I will do a separate PR for that. |
etoledom
left a comment
There was a problem hiding this comment.
As we agreed,
and move on! 🎉



Fixes #954
This PR addresses the issues iOS were empty lines are being added to new lists or quotes blocks.
It also fixes the placeholders visibility and style on both blocks.
To test:
Update release notes:
RELEASE-NOTES.txt.