Skip to content

Narrow blur on unmount to replaceable#1128

Merged
hypest merged 7 commits intorelease/1.7.0from
fix/narrow-blur-on-unmount-to-replaceable
Jun 13, 2019
Merged

Narrow blur on unmount to replaceable#1128
hypest merged 7 commits intorelease/1.7.0from
fix/narrow-blur-on-unmount-to-replaceable

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Jun 13, 2019

Fixes #1126

Gutenberg PR: WordPress/gutenberg#16151

To test:

  1. Remove all the content
  2. Insert an image
  3. Remove the image
  4. Ensure there's no crash

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

hypest added 2 commits June 13, 2019 12:14
We need to have the RichText in a replaceable block blur on unmount
because it won't have the chance to do it on its componentDidUpdate.
@hypest hypest added this to the v1.7 milestone Jun 13, 2019
@hypest hypest requested review from daniloercoli and marecar3 June 13, 2019 12:02
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@SergioEstevao
Copy link
Copy Markdown
Contributor

Working fine on iOS too.

@hypest hypest merged commit fda80a8 into release/1.7.0 Jun 13, 2019
@hypest hypest deleted the fix/narrow-blur-on-unmount-to-replaceable branch June 13, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants