Skip to content

Improve copy paste of lists#1108

Merged
SergioEstevao merged 1 commit intodevelopfrom
issue/improve_copy_paste_of_lists
Jun 11, 2019
Merged

Improve copy paste of lists#1108
SergioEstevao merged 1 commit intodevelopfrom
issue/improve_copy_paste_of_lists

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Jun 10, 2019

This PR improves the copy paste of lists inside GB mobile by replacing paragraph separators for line feeds.
This allows the paste code in GB to recognize the lists better when pasting inside another block.

To test:

  • Start the demo app
  • Copy a list block by doing select all copy on it
  • Paste the resulting code inside another text block.
  • See that a list block is created.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label Jun 10, 2019
@SergioEstevao SergioEstevao added this to the v1.7 milestone Jun 10, 2019
@SergioEstevao SergioEstevao requested a review from etoledom June 10, 2019 14:46
@SergioEstevao SergioEstevao changed the title Improve copy past of lists Improve copy paste of lists Jun 10, 2019
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! Thank you @SergioEstevao 🎉

Now pasting lists content on Paragraph/Heading blocks work in the same way than on web.
Android seems to be working well from before. 👍

@SergioEstevao SergioEstevao merged commit 406c201 into develop Jun 11, 2019
@SergioEstevao SergioEstevao deleted the issue/improve_copy_paste_of_lists branch June 11, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants