Avoid sending onEnter when AztecView is not focused.#1065
Merged
Conversation
This helps avoiding some focus loop issues.
SergioEstevao
approved these changes
Jun 4, 2019
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Working great! Thanks for this fix!
Contributor
Author
|
Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1063
fixes wordpress-mobile/WordPress-iOS#11583
The issue happens when the blur event takes longer to get to the native side than the second Enter. When this happens, a second onEnter -> onSplit chain of events is fired while the first one is still occurring. This seems to be confusing for the gutenberg store.
This doesn't happen on Android because of this:
gutenberg-mobile/react-native-aztec/src/AztecView.js
Lines 153 to 155 in ec43c9f
On Android the focus-blur loop is broken there, but on iOS this is needed to solve this issue #784
To test:
Update release notes:
RELEASE-NOTES.txt.