Skip to content

List block design review #897

@iamthomasbishop

Description

@iamthomasbishop

While giving the latest alpha of WPAndroid (alpha-165), I noticed a few things that could use some refinement. Because I was previously out for ~5 weeks, I'm not sure which/if any are in progress or fixed. With that said, here are the things that jumped out at me (and some redlines from the original block design for reference):

Screen Shot 2019-04-19 at 12 35 20 PM

(above: proposed block design)

Screen Shot 2019-04-19 at 12 59 43 PM

(left: current implementation, right: proposed)

Visual refinements

  • List items don't have vertical spacing between – there should be 10pt between items
  • Left edge of list should be aligned left to 16pt keyline (aligned flush left of inner block)
  • Bullet (unordered lists) should be 6pt
  • Space between bullet and text should be 10pt (total text inset == 32pt)
  • It appears that on unordered lists, the bullet is 1-2pt below center
  • Line-height on items should be 24pt
  • Top-level bullets should be same color as text
  • Nested items' list-style-type should be circle

Bugs

Side note: I think on Android, there might be a regression on inner block padding, where there's too much padding along the top and bottom edges of inner blocks – something we fixed previously?

cc @SergioEstevao @etoledom @hypest

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions