-
Notifications
You must be signed in to change notification settings - Fork 57
List block design review #897
Copy link
Copy link
Closed
Labels
Blocks[OS] Android[Type] BugSomething isn't workingSomething isn't working[Type] EnhancementImproves a current area of the editorImproves a current area of the editor
Description
While giving the latest alpha of WPAndroid (alpha-165), I noticed a few things that could use some refinement. Because I was previously out for ~5 weeks, I'm not sure which/if any are in progress or fixed. With that said, here are the things that jumped out at me (and some redlines from the original block design for reference):
(above: proposed block design)
(left: current implementation, right: proposed)
Visual refinements
- List items don't have vertical spacing between – there should be 10pt between items
- Left edge of list should be aligned left to 16pt keyline (aligned flush left of inner block)
- Bullet (unordered lists) should be 6pt
- Space between bullet and text should be 10pt (total text inset == 32pt)
- It appears that on unordered lists, the bullet is 1-2pt below center
- Line-height on items should be 24pt
- Top-level bullets should be same color as text
- Nested items'
list-style-typeshould becircle
Bugs
- Crash on switching to / creating of ordered list
- Hitting return twice doesn't escape block + create next one
- If you tap into a nested list item, then hit return, the last character gets included in the return to the next line
Side note: I think on Android, there might be a regression on inner block padding, where there's too much padding along the top and bottom edges of inner blocks – something we fixed previously?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Blocks[OS] Android[Type] BugSomething isn't workingSomething isn't working[Type] EnhancementImproves a current area of the editorImproves a current area of the editor

