-
Notifications
You must be signed in to change notification settings - Fork 57
Pasting external content - known issues #624
Copy link
Copy link
Open
Labels
Writing Flow[Pri] Low[Type] EnhancementImproves a current area of the editorImproves a current area of the editor
Description
This issue is a follow-up to #238. First steps have been taken to implement pasting with the merging of #553 and WordPress/gutenberg#13841, however, additional work is required. Known issues and additional work needed are listed below.
Known issues
- Pasting into selected text causes a red screen -
TypeError: this.props.value.trimLeft is not a function(was working before merging recent changes to RichText - may be related togetRecord) - (fixed with PR Fixes a red sceen when pasting. #638) - Pasting from some sources causes a red screen (related comment, fixed with PR Fix for node.rel crash #630)
- Pasting images along with text sometimes omits the images #827 Pasting images along with text sometimes omits the images (related comment) (fixed with Implement jsdom node traversal properties #1083)
- When bullet lists are copied to the clipboard and pasted to a paragraph block, the bullets are lost. Currently, list blocks are not supported. When support is added, behavior should be tested again.
- Fix pasting into heading blocks (see known issues in PR First steps to implement pasting external content #553)
-
Fix pasting into code blocks (see known issues in PR First steps to implement pasting external content #553)-> Code block #822 - After pasting, cursor should move to the end of the pasted content #828 Fix cursor position after paste (see known issues in PR First steps to implement pasting external content #553)
- Fix or log loss of inline styles on pasted span tags
- Fix pasting URLs with a selection (fixed with PR [iOS] Fix for a links pasting issue #644).
- Pasting inline text into a link splits the link apart Pasting inline text into a link splits the link apart #839
Additional work
- Add try/catch fallback to plain text to guard against errors (in production) in unexplored code paths, in lieu of testing (fixed with PR Implement pasteHandler with plain text fallback #646)
- Improve comments in
jsdom-patches.js(related comment) (PR Add comments to clarify functions in jsdom-patches file. #826) - Log feature degradation caused by mobile DOM (related comment)
- Research additional patches for
jsdom-jscoreto support missing features from web code - Refactor
splitContentto a common interface with web, consider using options object (related comment) - Handle deprecation of
onSplitas discussed here. Related: RichText: mark onSplit prop as unstable #394 - Create tests (manual tests here as starting point) (UI tests added here: Add Paste UI Tests for Android #1100)
- Support normalizing inline styles on
<span>tags (details here) - Support for third party keyboard / clipboard managers
- Target 3 from Pasting external content #238 (WP apps, unsupported blocks, and uploading images on the spot)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Writing Flow[Pri] Low[Type] EnhancementImproves a current area of the editorImproves a current area of the editor