Skip to content

Refine inner block margins #547

@iamthomasbishop

Description

@iamthomasbishop

Inner block paddings are a bit loose right now, let's make sure these are refined.

Block Anatomy

By default, every block type (including Title) contains internal padding of 12pt top/bottom and 16pt left/right.

Static

image

Focused

When a block is focused, we show the inline toolbar (44pt height) and collapse the margin-bottom, like so:

image

Currently

(proper paddings indicated with green, improper in red)

Android:

image

As you can see, left/right paddings on Android are 👍 , however top/bottom paddings are a bit off.

iOS:

ios

Punch-list

Both Platforms

  • Ensure padding-top is always 12 (static + focused)
  • Remove padding-bottom when block is focused

iOS

  • Ensure padding on left/right sides is 16pt

Metadata

Metadata

Labels

[Type] EnhancementImproves a current area of the editor

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions