This repository was archived by the owner on Mar 7, 2025. It is now read-only.
iOS: Add Slack notifications and safety checks to publish-podspec#38
Merged
iOS: Add Slack notifications and safety checks to publish-podspec#38
Conversation
jkmassel
suggested changes
Oct 2, 2019
Contributor
There was a problem hiding this comment.
It looks like the example isn't passing:
warning: Capabilities for Signing & Capabilities may not function correctly
because its entitlements use a placeholder team ID. To resolve this, select
a development team in the App editor. (in target 'App' from project 'App')
warning: Skipping code signing because the target does not have an
Info.plist file and one is not being generated automatically. (in target
'App' from project 'App')
These are warnings we could probably ignore, but I'm not sure we want to run this with --allow-warnings. WDYT?
Contributor
Author
|
The cause of the warning was actually: That was because I was running it on a branch instead of a tag for testing purposes. I have made a new, working test build here. It also posted successfully to Slack:
I think we should avoid |
jkmassel
approved these changes
Oct 3, 2019
Contributor
jkmassel
left a comment
There was a problem hiding this comment.
Nice – it's passing now, and I see the notification in Slack.
Looks good!
This was referenced Oct 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have now been using this command successfully with WordPressAuthenticator for a few weeks. This adds a few minor improvements before I start rolling it out more widely:
$CIRCLE_TAGmatches the version in the podspec.You can see it working here.