Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Refactor the logic to fetch metadata of VideoPress videos#581

Merged
fluiddot merged 19 commits into
trunkfrom
add/media-videopress-token
Mar 17, 2023
Merged

Refactor the logic to fetch metadata of VideoPress videos#581
fluiddot merged 19 commits into
trunkfrom
add/media-videopress-token

Conversation

@fluiddot

@fluiddot fluiddot commented Feb 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR exposes the endpoint to fetch the VideoPress token which is required to play private videos (internal discussion - p9ugOq-3sW-p2). As well as replace the previous function to fetch VideoPress video metadata (i.e. getVideoURLFromVideoPressID) with a new version that retrieves all metadata parameters.

Related to wordpress-mobile/gutenberg-mobile#5512.

Testing Details

Follow testing instructions from wordpress-mobile/WordPress-iOS#20237.

  • Please check here if your pull request includes additional test coverage.
  • I have considered updating the version in the .podspec file.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@fluiddot fluiddot self-assigned this Feb 28, 2023
@fluiddot fluiddot changed the title Implement VideoPress token fetch Implement VideoPress metadata fetch Mar 2, 2023
@fluiddot fluiddot force-pushed the add/media-videopress-token branch 6 times, most recently from fbdd15b to f44f935 Compare March 2, 2023 17:44
@fluiddot fluiddot changed the title Implement VideoPress metadata fetch Refactor the logic to fetch metadata of VideoPress videos Mar 2, 2023
@fluiddot fluiddot mentioned this pull request Mar 2, 2023
Merged
4 tasks
@fluiddot fluiddot force-pushed the add/media-videopress-token branch from fa6e7d1 to 49a03dc Compare March 8, 2023 13:11
@fluiddot fluiddot force-pushed the add/media-videopress-token branch from 49a03dc to 0047e08 Compare March 8, 2023 13:17
@fluiddot
Merge branch 'trunk' into add/media-videopress-token
d3a49a1 
# Conflicts:
#	WordPressKit.podspec
@fluiddot fluiddot marked this pull request as ready for review March 8, 2023 13:20
@fluiddot fluiddot force-pushed the add/media-videopress-token branch from b5f4ca9 to 62aa2a1 Compare March 9, 2023 11:43
@fluiddot fluiddot force-pushed the add/media-videopress-token branch from 62aa2a1 to 4ccbf10 Compare March 9, 2023 11:44
twstokes
twstokes reviewed Mar 12, 2023
View reviewed changes

@twstokes twstokes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good @fluiddot - thanks for taking it on!

I've left some comments in the PR and after we resolve those I can start testing. Thanks!

Comment thread WordPressKit.podspec Outdated
Comment thread WordPressKit/RemoteVideoPressVideo.swift Outdated
Comment thread WordPressKit/RemoteVideoPressVideo.swift Outdated
Comment thread WordPressKit/RemoteVideoPressVideo.swift Outdated
Comment thread WordPressKit/RemoteVideoPressVideo.swift Outdated
@fluiddot

fluiddot commented Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @twstokes for the review, I really appreciate it 🙇. I applied the different suggestions so the PR is ready for another review. Let me know if you could take a look, thanks!

Due to this change d77b947, I'll update the parent PR accordingly to the change.

@fluiddot fluiddot requested a review from twstokes March 13, 2023 11:05
@fluiddot fluiddot mentioned this pull request Mar 13, 2023
Merged
1 task
@fluiddot

fluiddot commented Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

Due to this change d77b947, I'll update the parent PR accordingly to the change.

Updated in wordpress-mobile/WordPress-iOS@82d800c.

twstokes
twstokes approved these changes Mar 15, 2023
View reviewed changes

@twstokes twstokes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @fluiddot! Great work. 🚀

@fluiddot
Merge branch 'trunk' into add/media-videopress-token
8a6a03b 
# Conflicts:
#	WordPressKit.podspec
@fluiddot fluiddot mentioned this pull request Mar 17, 2023
Merged
4 tasks
@fluiddot fluiddot merged commit 8f1d2fe into trunk Mar 17, 2023
@fluiddot fluiddot deleted the add/media-videopress-token branch March 17, 2023 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@twstokes twstokes twstokes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fluiddot fluiddot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fluiddot @twstokes