Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

[Gutenberg] Pass the Gallery v2 Flag over from the editor#417

Merged
antonis merged 13 commits intodevelopfrom
rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2
Sep 2, 2021
Merged

[Gutenberg] Pass the Gallery v2 Flag over from the editor#417
antonis merged 13 commits intodevelopfrom
rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2

Conversation

@chipsnyder
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder commented Jul 8, 2021

Related PRs
gutenberg: WordPress/gutenberg#33314
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3713
WordPress-iOS: wordpress-mobile/WordPress-iOS#16832

Description

This PR is built off of #416 That PR should be reviewed and merged before this one.

Testing Details

This can be tested with the instructions contained here: WordPress/gutenberg#33314

  • Please check here if your pull request includes additional test coverage.

@chipsnyder chipsnyder force-pushed the rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2 branch from 1f1b500 to bd0da2a Compare July 9, 2021 18:08
@chipsnyder chipsnyder requested a review from antonis July 9, 2021 21:05
@chipsnyder chipsnyder added the enhancement New feature or request label Jul 9, 2021
@chipsnyder chipsnyder marked this pull request as ready for review July 9, 2021 21:05
@chipsnyder chipsnyder changed the base branch from develop to gutenberg/gss/endpoint_update July 12, 2021 19:22
Base automatically changed from gutenberg/gss/endpoint_update to develop July 14, 2021 19:17
Copy link
Copy Markdown

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chipsnyder 👍
This LGTM and works as expected 🎉

…-blocks-editor-settings_v2

# Conflicts:
#	WordPressKit.podspec
@antonis antonis self-assigned this Sep 1, 2021
@antonis antonis requested a review from mkevins September 1, 2021 08:57
Copy link
Copy Markdown
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via: wordpress-mobile/WordPress-iOS#16832 (review) and everything is working as expected. Thanks! 👍

…-blocks-editor-settings_v2

# Conflicts:
#	WordPressKit.podspec
@antonis antonis merged commit 53c3013 into develop Sep 2, 2021
@antonis antonis deleted the rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2 branch September 2, 2021 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants