Add Jetpack backup and restore endpoints#321
Conversation
emilylaguna
left a comment
There was a problem hiding this comment.
Nice! Looking good. I left a couple suggestions below. I'm also thinking we should preface some of the generic class names such as Backup and RestoreTypes with Jetpack to prevent any confusion in the future.
What do you think?
| /// | ||
| /// - Returns: A restoreID to check the status of the rewind request. | ||
| /// | ||
| @objc public func restoreSite(_ siteID: Int, |
There was a problem hiding this comment.
I don't think this method is used in any Objective-C files so I'm thinking we can drop the @objc modifier. Thoughts?
|
@emilylaguna Thanks for reviewing! Addressed the suggestions -- back to you! |
emilylaguna
left a comment
There was a problem hiding this comment.
👋 Sorry it took so long for me to re-review. I left a few comments below for ya. let me know your thoughts.
| @@ -0,0 +1,30 @@ | |||
| import Foundation | |||
|
|
|||
| public class JetpackRestoreTypes: NSObject { | |||
There was a problem hiding this comment.
What do you think about converting this into a struct so we can remove the init boilerplate code.
emilylaguna
left a comment
There was a problem hiding this comment.
Nice work! Looks good to me! 🚢
Description
BackupmodelRestoreTypesmodelRestoreTypesparam for restoreSite endpointTesting Details
🟢 Tests should be good!