Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Add get activity groups endpoint#306

Merged
momo-ozawa merged 11 commits intodevelopfrom
task/add_get_activity_groups_endpoint
Dec 1, 2020
Merged

Add get activity groups endpoint#306
momo-ozawa merged 11 commits intodevelopfrom
task/add_get_activity_groups_endpoint

Conversation

@momo-ozawa
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa commented Nov 27, 2020

Description

This new endpoint will be used to get the available Activity Types in the Activity Log. Documentation about the parameters can be found in the code.

Testing Details

🟢 Tests should be good!

  • Please check here if your pull request includes additional test coverage.

@momo-ozawa momo-ozawa self-assigned this Nov 27, 2020
Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@momo-ozawa added a few comments. Basically, we need to:

  • Add date range parameters
  • Add the key value to the model (which is used to filter the results)

@momo-ozawa momo-ozawa changed the title Task/add get activity groups endpoint Add get activity groups endpoint Nov 30, 2020
Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@momo-ozawa momo-ozawa merged commit d5590a5 into develop Dec 1, 2020
@momo-ozawa momo-ozawa deleted the task/add_get_activity_groups_endpoint branch December 1, 2020 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants