Description

🙇‍♀️ I apologize this PR got bigger than I originally intended. The threat models ended up being a lot more complex.

There isn't a related WPiOS PR yet, so the tests being green and a thorough code review will work 👍

This PR introduces the JetpackScanServiceRemote class that contains the method for starting a scan and getting scan information (status, availability, threats, etc). Since the API only uses 1 endpoint for getting scan information (sites/SITE_ID/scan) I've added a few "helper" methods to reduce the amount of information returned by the getScanForSite method:

• getScanAvailableForSite just returns the isEnabled bool
• getCurrentScanStatusForSite just returns the current scan status if it exists
• getThreatsForSite just returns the threats array

Threats

I had originally planned on creating sub threat objects like JetpackThreatCore, JetpackThreatDatabase and only including the relevant properties for that type, but I couldn't get that to work within the decodable structure. Looking for suggestions to make this a bit cleaner.

The JetpackScanThreat object is A LOT to look at so I'll provide any relevant information I can think of:

• The API does not return the threat type so we have to figure that out ourselves. Luckily wp-calypso already had this logic.

• The fixable property points to a "Fixer" object that defines how a threat will be fixed if it can be. This information will be used to generate a string later such as "Jetpack will update this plugin to version 1.3.3.7"

  • If a threat can not be fixed this object is nil.

• JetpackThreatContext:

  • This defines a code preview for file based threats with highlighted sections
  • was created with the intent of using it later to generate an NSAttributedString which is why I opted to use NSRange's
  • The value from the API can be:
    • Not present for non-file threats
    • An empty string context: ""
    • A dictionary
  • The logic for this is kind of messy 😑 looking for suggestions to improve.

Testing Details

🟢 Tests should be good!

• Please check here if your pull request includes additional test coverage.