This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Conversation
b3f29fb to
71451f4
Compare
bjtitus
reviewed
Sep 12, 2020
| return | ||
| } | ||
|
|
||
| return strongSelf.urlSession(session, didReceive: authenticationChallenge, completionHandler: completionHandler) |
Contributor
There was a problem hiding this comment.
@jkmassel I think it's sufficient to not return the result here. The return type is Void anyway.
This means we don't need the guard let strongSelf = self above either.
7e47e90 to
6f44c37
Compare
Xcode 12 didn’t like it
Fixes Xcode 12 warnings
d61129a to
16aa796
Compare
bjtitus
approved these changes
Sep 16, 2020
Contributor
bjtitus
left a comment
There was a problem hiding this comment.
Build and ran using Xcode 12 and did not see any warnings.
Contributor
Author
|
Thanks @bjtitus!! |
Contributor
|
Thanks for fixing this! |
This was referenced Sep 21, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes changes to the project required to support Xcode 12, including: