This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Handle user canceled "error" in demo app#762
Merged
Merged
Conversation
mokagio
commented
Mar 27, 2023
Comment on lines
+100
to
+102
| } catch let error as NSError where | ||
| error.domain == ASWebAuthenticationSessionError.errorDomain | ||
| && error.code == ASWebAuthenticationSessionError.Code.canceledLogin.rawValue { |
Contributor
Author
There was a problem hiding this comment.
I you ask Xcode, it will indent this as:
} catch let error as NSError where
error.domain == ASWebAuthenticationSessionError.errorDomain
&& error.code == ASWebAuthenticationSessionError.Code.canceledLogin.rawValue {That doesn't make any sense to me, so I updated it manually.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #761, I realized the demo app would crash when canceling ("Cancel" button) the web login.
This fixes it.
Testing
I verified this by running the app and pressing the "Cancel" button 😅
CHANGELOG.mdif necessary.