Closed
Conversation
JSON parsing is still quite unstable and can crash on self hosted sites with older Jetpack versions.
Moved storage to core data and use a NSFetchedResultsController for change notification
I wanted to move networking code out of the view layer, but let's start with something that works and build from there.
Member
Author
|
Closing this one for now as I'll be working on other stuff for a bit. Most of the work is to be merged in #4384 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will allow user management in the app:
Out of scope for this PR:
Checklist:
PostSettingsSelectionViewControllerto make it generic for role selectionsetAvatarURLto a helperWPTableViewHandlerPersonjust before merging