Skip to content

Update Gifu to 3.3.1#21161

Merged
kean merged 3 commits intotrunkfrom
task/update-gifu
Jul 21, 2023
Merged

Update Gifu to 3.3.1#21161
kean merged 3 commits intotrunkfrom
task/update-gifu

Conversation

@kean
Copy link
Copy Markdown
Contributor

@kean kean commented Jul 21, 2023 •
edited
Loading

Fixes #21160

Fortunately, I fixed this crash in Gifu two years ago 😃

The latest version is 3.4.0, but it is not on CocoaPods.

To test:

The crash is a race condition and you have to be very unlucky to reproduce it.

Regression Notes

  1. Potential unintended areas of impact: GIF rendering
  2. What I did to test those areas of impact (or what existing automated tests I relied on): tested manually
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean added this to the Pending milestone Jul 21, 2023
@kean kean requested review from guarani and staskus July 21, 2023 01:37
@kean kean marked this pull request as draft July 21, 2023 01:42
kean
kean commented Jul 21, 2023
View reviewed changes
WordPress/Classes/ViewRelated/Media/CachedAnimatedImageView.swift
animatedGifData = data
DispatchQueue.main.async() {
self.setFrameBufferCount(self.gifPlaybackStrategy.frameBufferCount)
self.animate(withGIFData: data) {
Copy link
Copy Markdown
Contributor Author

@kean kean Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If fixes the this new-ish warning: https://github.com/apple/swift-evolution/blob/main/proposals/0286-forward-scan-trailing-closures.md

@kean kean marked this pull request as ready for review July 21, 2023 01:56
@kean kean mentioned this pull request Jul 21, 2023
Merged
4 tasks
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jul 21, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21161-d4c4c29
Version22.8
Bundle IDorg.wordpress.alpha
Commitd4c4c29
App Center BuildWPiOS - One-Offs #6477
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jul 21, 2023 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21161-d4c4c29
Version22.8
Bundle IDcom.jetpack.alpha
Commitd4c4c29
App Center Buildjetpack-installable-builds #5508
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

staskus
staskus approved these changes Jul 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately, I fixed this crash in Gifu two years ago 😃

Okay 😅

Power of open source integrating your own changes from 2 years ago 👏

@kean kean force-pushed the task/update-gifu branch from c5d8dee to 85b92f3 Compare July 21, 2023 20:16
@kean kean enabled auto-merge July 21, 2023 20:18
@kean kean merged commit 54b74af into trunk Jul 21, 2023
@kean kean deleted the task/update-gifu branch July 21, 2023 21:22
@kean kean mentioned this pull request Jul 14, 2023
Open
@staskus staskus modified the milestones: Pending, 22.9 ❄️ Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staskus staskus staskus approved these changes

@guarani guarani Awaiting requested review from guarani

Assignees

No one assigned

Labels

[Type] Crash

Projects

None yet

Milestone

22.9

Development

Successfully merging this pull request may close these issues.

Crash when updating FrameStore in background (Gifu)

3 participants

@kean @wpmobilebot @staskus