Add build phase to detect nested frameworks#21130
Add build phase to detect nested frameworks#21130mokagio merged 3 commits intomokagio/gutenberg-xcframework-setupfrom
Conversation
| #!/bin/sh -eu | ||
|
|
||
| set pipefail |
There was a problem hiding this comment.
I only now notice that the shebang doesn't use Bash. Possibly why I ShellCheck warned me about having pipefail in there.
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "\"$SRCROOT/../Scripts/BuildPhases/LintNestedFrameworks.sh\"\n"; | ||
| }; |
There was a problem hiding this comment.
We need the build phase in both WordPress and Jetpack. We cannot run this before building the apps in a centralized aggregated target because the script looks into the target's frameworks.
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21130-723f8ed | |
| Version | 22.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 723f8ed | |
| App Center Build | WPiOS - One-Offs #6425 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21130-723f8ed | |
| Version | 22.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 723f8ed | |
| App Center Build | jetpack-installable-builds #5453 |
There was a problem hiding this comment.
I wonder who wrote that shell script 
but it looks great 😃
See #21129 picking up the issue in the "faulty" Gutenberg version.
👌
I left a comment to suggest keeping the P2 post reference, as it can still be helpful for the screenshots and explanations it provides. Other than that, LGTM 👍
Co-authored-by: Olivier Halligon <olivier.halligon@automattic.com>
|
For the record, I did not miss the RuboCop violation in CI. I decided to ignore it because it's unrelated to the changes in this PR and the Ruby code is being modified elsewhere in #21021 |
The Hermes nested framework issue that gave us some grief could have been avoided if we had preemptively checked against that kind of setup.
The issue should be fixed now (either via #21021 or #21128) but we can benefit with this check to avoid paying the price again in the future.
How to test
See #21129 picking up the issue in the "faulty" Gutenberg version.
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary. N.A.UI changes testing checklist: Not a UI PR.