Declare a delegate property as a weak reference in WebKitViewController#21051
Merged
crazytonyli merged 5 commits intotrunkfrom Jul 19, 2023
Merged
Declare a delegate property as a weak reference in WebKitViewController#21051crazytonyli merged 5 commits intotrunkfrom
crazytonyli merged 5 commits intotrunkfrom
Conversation
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21051-7b35097 | |
| Version | 22.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 7b35097 | |
| App Center Build | WPiOS - One-Offs #6286 |
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21051-51b3e8d | |
| Version | 22.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 51b3e8d | |
| App Center Build | jetpack-installable-builds #5422 |
mokagio
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #21050.
The same property is declared as weak references in
WordPress-iOS/WordPress/Classes/Utility/WPWebViewController.m
Line 45 in 09143b4
WordPress-iOS/WordPress/Classes/Utility/WebViewControllerConfiguration.swift
Line 18 in 09143b4
I don't see why we should not declare it as a weak reference in
WebKitViewController.Also, this property causes a memory leak in Themes. Here are the steps to reproduce the memory leak.
deinitfunction toThemeBrowserViewControllerand add a breakpoint in this function.Regression Notes
Potential unintended areas of impact
None.
ThemeWebNavigationDelegateis the only type that implements theWebNavigationDelegateprotocol.What I did to test those areas of impact (or what existing automated tests I relied on)
Verified the issue can no longer be reproduced on this PR.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A