Skip to content

Update logic for GutenbergViewController to fix media upload statuses#19573

Merged
geriux merged 1 commit intogutenberg/react-native-0.69from
gutenberg/stop-upload-button
Nov 16, 2022
Merged

Update logic for GutenbergViewController to fix media upload statuses#19573
geriux merged 1 commit intogutenberg/react-native-0.69from
gutenberg/stop-upload-button

Conversation

@derekblank
Copy link
Copy Markdown
Contributor

@derekblank derekblank commented Nov 9, 2022

Fixes wordpress-mobile/gutenberg-mobile#5254

To test:

  • Tap on the Image block placeholder or edit button in the toolbar
  • Tap option ‘Choose from device’ and choose an image
  • While the upload is in progress tap on the image thumbnail
  • Stop upload button should be present in ActionSheet options

Regression Notes

  1. Potential unintended areas of impact
    Gutenberg Editor

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@derekblank derekblank requested a review from geriux November 9, 2022 04:30
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Nov 9, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19573-f3f9fc7 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Nov 9, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19573-f3f9fc7 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@geriux
Copy link
Copy Markdown
Contributor

geriux commented Nov 16, 2022 •
edited
Loading

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Video block - 1

  • Video block - Insert video from device (failing) - steps

geriux
geriux approved these changes Nov 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 👏 I've tested different scenarios and its working well.

@geriux geriux merged commit 6fcdba9 into gutenberg/react-native-0.69 Nov 16, 2022
@geriux geriux deleted the gutenberg/stop-upload-button branch November 16, 2022 13:25
@geriux geriux mentioned this pull request Nov 17, 2022
Closed
@geriux geriux mentioned this pull request Dec 7, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Gutenberg Mobile: React Native 0.69 Upgrade
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derekblank @wpmobilebot @geriux