Skip to content

Integrate gutenberg-mobile release 1.79.0#19004

Merged
dcalhoun merged 20 commits intotrunkfrom
gutenberg/integrate_release_1.79.0
Jul 8, 2022
Merged

Integrate gutenberg-mobile release 1.79.0#19004
dcalhoun merged 20 commits intotrunkfrom
gutenberg/integrate_release_1.79.0

Conversation

@dcalhoun
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun commented Jul 7, 2022

Description

This PR incorporates the 1.79.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#5011

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

dcalhoun added 9 commits June 21, 2022 11:12
When the alt text for a media item is present in the media library, that
value should be copied into the Image block when inserted. This behavior
avoids the need to re-enter the alt text for each image inserted into
the post content.
…WordPress-iOS into fix/image-block-preserves-alt-text
…rves-alt-text

fix: Image block preserves alt text from media library
@dcalhoun dcalhoun added the Gutenberg Editing and display of Gutenberg blocks. label Jul 7, 2022
@dcalhoun dcalhoun added this to the 20.3 milestone Jul 7, 2022
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jul 7, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19004-37899e4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Integrate pending Gutenberg Mobile 1.79.0 changes
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jul 7, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19004-37899e4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@dcalhoun dcalhoun marked this pull request as ready for review July 7, 2022 19:27
@dcalhoun dcalhoun requested a review from derekblank July 7, 2022 19:28
Podfile Outdated
## =====================
##
gutenberg tag: 'v1.78.1'
gutenberg :tag => '1.79.0'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Use the new Ruby 1.9 hash syntax.

Podfile Outdated
## =====================
##
gutenberg tag: 'v1.78.1'
gutenberg :tag => '1.79.0'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tag has the wrong format, it should be v1.79.0.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this issue in bb86263.

Podfile Outdated
## =====================
##
gutenberg tag: 'v1.78.1'
gutenberg :tag => 'v1.79.0'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Use the new Ruby 1.9 hash syntax.

Podfile Outdated
## =====================
##
gutenberg tag: 'v1.78.1'
gutenberg :tag => 'v1.79.0'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why the tag format has been changed 🤔, should we use :tag instead?

Copy link
Copy Markdown
Contributor

@fluiddot fluiddot Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed this issue in 73eb00b.

@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@dcalhoun dcalhoun merged commit 87d9b42 into trunk Jul 8, 2022
@dcalhoun dcalhoun deleted the gutenberg/integrate_release_1.79.0 branch July 8, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants