Skip to content

[Site Design Revamp] Reduce recommended design thumbnail sizes#18879

Merged
mokagio merged 1 commit intorelease/20.1from
task/site-design-recommended-thumbnail-size
Jun 16, 2022
Merged

[Site Design Revamp] Reduce recommended design thumbnail sizes#18879
mokagio merged 1 commit intorelease/20.1from
task/site-design-recommended-thumbnail-size

Conversation

@twstokes
Copy link
Copy Markdown
Contributor

@twstokes twstokes commented Jun 14, 2022

Fixes #18878

iPhone Before iPhone After
Simulator Screen Shot - iPhone 13 - 2022-06-14 at 10 56 42 Simulator Screen Shot - iPhone 13 - 2022-06-14 at 11 14 19
iPad Before iPad After
Simulator Screen Shot - iPad (9th generation) - 2022-06-14 at 10 58 41 Simulator Screen Shot - iPad (9th generation) - 2022-06-14 at 11 06 46

To test:

  1. Start the Site Creation flow
  2. Navigate to the Site Design screen
  3. Expect the thumbnails in the recommended section to match the size and quality of the other thumbnails

Regression Notes

  1. Potential unintended areas of impact
  • None.
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Manual, visual testing.
  1. What automated tests I added (or what prevented me from doing so)
  • None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes added this to the 20.1 ❄️ milestone Jun 14, 2022
@twstokes twstokes requested a review from a team June 14, 2022 15:32
@twstokes twstokes self-assigned this Jun 14, 2022
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jun 14, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18879-1eb6b22 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jun 14, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18879-1eb6b22 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Gio2018
Gio2018 approved these changes Jun 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

@twstokes
Copy link
Copy Markdown
Contributor Author

twstokes commented Jun 14, 2022

Thanks @Gio2018! Will leave this open for @mokagio to merge at will. 🙇

@mokagio
Copy link
Copy Markdown
Contributor

mokagio commented Jun 16, 2022

@twstokes

merge at will

Off we merge, then 😄

But, I won't be shipping a beta for this just yet and wait till early next week. If that's a problem for you please let me know. FYI, I'll be AFK tomorrow (my Friday, starting in ~12h) so you might have to ping the other @wordpress-mobile/owl-team folks if that's the case.

@mokagio mokagio merged commit 2974157 into release/20.1 Jun 16, 2022
@mokagio mokagio deleted the task/site-design-recommended-thumbnail-size branch June 16, 2022 02:55
@twstokes
Copy link
Copy Markdown
Contributor Author

twstokes commented Jun 16, 2022 •
edited
Loading

If that's a problem for you please let me know.

Not a problem at all @mokagio!

@mokagio mokagio mentioned this pull request Jun 20, 2022
Merged
7 tasks
@mokagio
Copy link
Copy Markdown
Contributor

mokagio commented Jun 20, 2022

@twstokes this has been bundled as part of 20.1 beta 2 (20.1.0.2).

Thanks for your work 🙌

This was referenced Jul 1, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Gio2018 Gio2018 Gio2018 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@twstokes twstokes

Labels

Site Creation [Type] Task

Projects

None yet

Milestone

20.1

Development

Successfully merging this pull request may close these issues.

4 participants

@twstokes @wpmobilebot @mokagio @Gio2018