Skip to content

Quick Start: Fix quick actions auto scrolling in RTL#18810

Merged
hassaanelgarem merged 1 commit intorelease/20.0from
fix/18798-qs-auto-scroll-rtl
Jun 3, 2022
Merged

Quick Start: Fix quick actions auto scrolling in RTL#18810
hassaanelgarem merged 1 commit intorelease/20.0from
fix/18798-qs-auto-scroll-rtl

Conversation

@hassaanelgarem
Copy link
Copy Markdown
Contributor

@hassaanelgarem hassaanelgarem commented Jun 2, 2022

Fixes #18798

Description

Fixes an issue where quick action buttons were not correctly scrolled to during quick start tours.

Simulator.Screen.Recording.-.iPhone.13.Pro.Max.-.2022-06-02.at.04.30.53.mp4

Testing Instructions

  1. Set the language to an RTL language (eg. Arabic)
  2. Run the app
  3. Set the initial screen to Home from App Settings
  4. Enable quick start for existing sites
  5. Start stats task
  6. Make sure the Stats button is correctly scrolled to.
  7. Finish the task
  8. Start the Media task
  9. Make sure the Media button is correctly scrolled to.

Regression Notes

  1. Potential unintended areas of impact
    Same behavior on LTR.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested manually
  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem hassaanelgarem added this to the 20.0 ❄️ milestone Jun 2, 2022
@hassaanelgarem hassaanelgarem self-assigned this Jun 2, 2022
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 2, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jun 2, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18810-a7cc44d on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jun 2, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18810-a7cc44d on your iPhone

If you need access to App Center, please ask a maintainer to add you.

leandroalonso
leandroalonso approved these changes Jun 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested RTL and LTR and it works as described! :shipit:

@hassaanelgarem hassaanelgarem merged commit f51ad75 into release/20.0 Jun 3, 2022
@hassaanelgarem hassaanelgarem deleted the fix/18798-qs-auto-scroll-rtl branch June 3, 2022 03:02
@mokagio mokagio mentioned this pull request Jun 3, 2022
Merged
7 tasks
@mokagio
Copy link
Copy Markdown
Contributor

mokagio commented Jun 3, 2022

@hassaanelgarem this has been bundled as part of 20.0 beta 1 (20.0.0.1).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

Assignees

@hassaanelgarem hassaanelgarem

Labels

None yet

Projects

None yet

Milestone

20.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hassaanelgarem @wpmobilebot @mokagio @leandroalonso