Skip to content

Fix Tracks event for adding domain to cart#18809

Merged
guarani merged 1 commit intorelease/20.0from
fix/domain-selection-tracks-event
Jun 2, 2022
Merged

Fix Tracks event for adding domain to cart#18809
guarani merged 1 commit intorelease/20.0from
fix/domain-selection-tracks-event

Conversation

@guarani
Copy link
Copy Markdown
Contributor

@guarani guarani commented Jun 1, 2022 •
edited
Loading

It's my understanding that the domains_dashboard_select_domain_tapped Tracks event should be fired when a domain is added to the cart from the "Search domains" screen. It looks like there was a typo and domains_dashboard_add_domain_tapped was being fired instead.

From what I can tell, this fix brings iOS in-line with Android, see code here:

https://github.com/wordpress-mobile/WordPress-Android/blob/a045c883a39f8228b1aeaa8392dd64f90517eeec/WordPress/src/main/java/org/wordpress/android/ui/domains/DomainSuggestionsViewModel.kt#L217-L225

To test

Test the fix

  1. Log in to the Jetpack app to manage a site
  2. On the My Site tab, tap Domains
  3. Tap "Search for a domain"
  4. Select a domain
  5. Tap "Select domain"
  6. Check that the correct event (domains_dashboard_select_domain_tapped) was fired
    • If you're using the Jetpack build on this PR, look in the app's Activity Log
    • If you're using Xcode, look in the Debug Console

Verify the bug (optional)

  1. Download the latest Jetpack iOS 20.0 from Test Flight, or checkout release/20.0
  2. Log in to the app to manage a site
  3. On the My Site tab, tap Domains
  4. Tap "Search for a domain"
  5. Select a domain
  6. Tap "Select domain"
  7. Verify that the incorrect event (domains_dashboard_add_domain_tapped) was fired
    • If you're using the Jetpack build on this PR, look in the app's Activity Log
    • If you're using Xcode, look in the Debug Console

Regression Notes

  1. Potential unintended areas of impact

This change should fix a straightforward bug. I suppose the only unintended impact would be if the new event is wrong

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Just manual testing.

  1. What automated tests I added (or what prevented me from doing so)

It could nice to add tests for tracks events for this feature. At the moment, I don't think it's worth it in this PR.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jun 1, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18809-1e404b0 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jun 1, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18809-1e404b0 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@guarani guarani changed the base branch from trunk to release/20.0 June 1, 2022 20:43
@guarani guarani added this to the 20.0 ❄️ milestone Jun 1, 2022
Fix Tracks event for adding domain to cart
1e404b0 
It's my understanding that the `domains_dashboard_select_domain_tapped` Tracks event should be fired when a domain is added to the cart from the "Search domains" screen. It looks like there was a typo and `domains_dashboard_add_domain_tapped` was being fired instead.

From what I can tell, this fix brings iOS in-line with Android, see code here:

https://github.com/wordpress-mobile/WordPress-Android/blob/a045c883a39f8228b1aeaa8392dd64f90517eeec/WordPress/src/main/java/org/wordpress/android/ui/domains/DomainSuggestionsViewModel.kt#L217-L225
@guarani guarani force-pushed the fix/domain-selection-tracks-event branch from 11bd37b to 1e404b0 Compare June 1, 2022 21:02
@guarani guarani marked this pull request as ready for review June 1, 2022 22:55
@guarani guarani requested a review from frosty June 1, 2022 22:56
@guarani
Copy link
Copy Markdown
Contributor Author

guarani commented Jun 1, 2022

👋 Hi @mokagio, this PR targeting the current beta.

frosty
frosty approved these changes Jun 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@frosty frosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for catching this!

@guarani guarani merged commit 65a6ff6 into release/20.0 Jun 2, 2022
@guarani guarani deleted the fix/domain-selection-tracks-event branch June 2, 2022 13:00
@mokagio mokagio mentioned this pull request Jun 3, 2022
Merged
7 tasks
@mokagio
Copy link
Copy Markdown
Contributor

mokagio commented Jun 3, 2022

@guarani this has been bundled as part of 20.0 beta 1 (20.0.0.1).

Thanks for your work 🙌

@guarani
Copy link
Copy Markdown
Contributor Author

guarani commented Jun 3, 2022

Thank you, @mokagio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frosty frosty frosty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Domains Jetpack App

Projects

None yet

Milestone

20.0

Development

Successfully merging this pull request may close these issues.

4 participants

@guarani @wpmobilebot @mokagio @frosty