Skip to content

Quick Start: Fix notifications waypoint for RTL locales#18659

Merged
hassaanelgarem merged 1 commit intorelease/19.9from
issue/18641-qs-notifications-rtl
May 19, 2022
Merged

Quick Start: Fix notifications waypoint for RTL locales#18659
hassaanelgarem merged 1 commit intorelease/19.9from
issue/18641-qs-notifications-rtl

Conversation

@hassaanelgarem
Copy link
Copy Markdown
Contributor

@hassaanelgarem hassaanelgarem commented May 18, 2022

Fixes #18641

Description

Fixes a bug where the notification waypoint was added to the My Site tab instaed of notifications tab in RTL locales.

LTR RTL
Simulator Screen Shot - iPhone 13 Pro - 2022-05-19 at 01 16 21 Simulator Screen Shot - iPhone 13 Pro - 2022-05-19 at 01 18 22

Testing Instructions

  1. Set device locale to an RTL language (Arabic)
  2. Enable quick start for existing site
  3. Start notifications tour
  4. Make sure that the waypoint is attached to the correct tab

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem hassaanelgarem added this to the 19.9 ❄️ milestone May 18, 2022
@hassaanelgarem hassaanelgarem requested a review from momo-ozawa May 18, 2022 23:26
@hassaanelgarem hassaanelgarem self-assigned this May 18, 2022
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 18, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18659-1a3c558 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 18, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18659-1a3c558 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

momo-ozawa
momo-ozawa approved these changes May 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hassaanelgarem
Copy link
Copy Markdown
Contributor Author

hassaanelgarem commented May 19, 2022

@mokagio FYI 🙏

@hassaanelgarem hassaanelgarem merged commit c305d85 into release/19.9 May 19, 2022
@hassaanelgarem hassaanelgarem deleted the issue/18641-qs-notifications-rtl branch May 19, 2022 14:03
@mokagio mokagio mentioned this pull request May 20, 2022
Merged
7 tasks
@mokagio
Copy link
Copy Markdown
Contributor

mokagio commented May 20, 2022

@hassaanelgarem this has been bundled as part of 19.9 beta 2 (19.9.0.2).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hassaanelgarem hassaanelgarem

Labels

None yet

Projects

None yet

Milestone

19.9

Development

Successfully merging this pull request may close these issues.

4 participants

@hassaanelgarem @wpmobilebot @mokagio @momo-ozawa