Skip to content

Quick Start for Existing Users: End current tour when switching blogs#18648

Merged
momo-ozawa merged 3 commits intotrunkfrom
fix/18645-qs-end-current-tour-on-blog-switch
May 19, 2022
Merged

Quick Start for Existing Users: End current tour when switching blogs#18648
momo-ozawa merged 3 commits intotrunkfrom
fix/18645-qs-end-current-tour-on-blog-switch

Conversation

@momo-ozawa
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa commented May 18, 2022 •
edited
Loading

Fixes #18645

Description

Fixed a bug where the current Quick Start tour wasn't being ended when switching blogs

How to test

Repeat the following steps for all Quick Start tours (i.e. Existing Site, New Site)

  1. Log into an account with more than one site
  2. Select Site A and start a QS flow
  3. Before completing the task, select Site B
  4. ✅ Verify: After switching to Site B, the notice for the task you started on Site A is dismissed

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@momo-ozawa momo-ozawa added this to the 19.9 ❄️ milestone May 18, 2022
@momo-ozawa momo-ozawa self-assigned this May 18, 2022
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 18, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18648-3d9cf73 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 18, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18648-3d9cf73 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 19, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

hassaanelgarem
hassaanelgarem approved these changes May 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@hassaanelgarem hassaanelgarem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! 🚀

One minor thing, when I open the site picker, and I choose the current blog I'm already in, the notice gets dismissed as well. What do you think? Should we keep the current progress in this case?

@momo-ozawa
Copy link
Copy Markdown
Contributor Author

momo-ozawa commented May 19, 2022

@hassaanelgarem Good catch! Fixed in 3d9cf73

@momo-ozawa momo-ozawa enabled auto-merge May 19, 2022 13:59
@momo-ozawa momo-ozawa merged commit c04a11c into trunk May 19, 2022
@momo-ozawa momo-ozawa deleted the fix/18645-qs-end-current-tour-on-blog-switch branch May 19, 2022 14:18
@momo-ozawa
Copy link
Copy Markdown
Contributor Author

momo-ozawa commented May 19, 2022

FYI @mokagio 🙇‍♀️

@momo-ozawa momo-ozawa mentioned this pull request May 19, 2022
Merged
4 tasks
@momo-ozawa
Copy link
Copy Markdown
Contributor Author

momo-ozawa commented May 19, 2022

Shoot, @mokagio I meant to target release/19.9 but I accidentally targeted trunk. Sorry for not catching this before merging -- I created a new PR targeting release/19.9 #18669

@mokagio
Copy link
Copy Markdown
Contributor

mokagio commented May 19, 2022

No worries at all @momo-ozawa. #18669 is all we need 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso Awaiting requested review from leandroalonso

1 more reviewer

@hassaanelgarem hassaanelgarem hassaanelgarem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@momo-ozawa momo-ozawa

Labels

None yet

Projects

None yet

Milestone

19.9

Development

Successfully merging this pull request may close these issues.

Quick Start: QS task continues after selecting another site in site picker.

4 participants

@momo-ozawa @wpmobilebot @mokagio @hassaanelgarem