[Gutenberg] Integrate React Native 0.66 upgrade of Gutenberg Mobile#17594
Merged
[Gutenberg] Integrate React Native 0.66 upgrade of Gutenberg Mobile#17594
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
c75baef to
cf1653b
Compare
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
cf1653b to
7cc8462
Compare
twstokes
commented
Nov 30, 2021
| @@ -472,9 +474,12 @@ post_install do |installer| | |||
| # ===================================== | |||
| # | |||
| installer.pods_project.targets.each do |target| | |||
Contributor
Author
There was a problem hiding this comment.
I didn't work to add this tweak because I believe this project now only compiles for Xcode 13+.
2 tasks
7cc8462 to
2f21583
Compare
6601b68 to
caa776d
Compare
This was referenced Dec 1, 2021
caa776d to
0a66cf2
Compare
Updates Pods to include the latest generated Podspec files for `gutenberg-mobile`.
…nto chore/upgrade-to-react-native-0.66
…nto chore/upgrade-to-react-native-0.66
dcalhoun
approved these changes
Jan 3, 2022
Member
dcalhoun
left a comment
There was a problem hiding this comment.
The changes in this PR make sense to me. Much of the WPiOS Writing Flow, Unsupported Block Editor, and additional features were tested against wordpress-mobile/gutenberg-mobile#4235.
LGTM. Before we merge this PR, we need to update the gutenberg Podfile reference to a new tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Gutenberg Mobile to include the upgrade to React Native 0.66.
Related PRs
Regression Notes
Regressions in the block editor from upgrading the foundational third-party dependency utilized.
Performed Gutenberg Mobile Writing Flow, UBE, and Sanity test cases.
Not really possible or relevant for this type of dependency upgrade work.
PR submission checklist:
RELEASE-NOTES.txtif necessary.