Skip to content

Jetpack Section: Scan dark mode support#15809

Merged
emilylaguna merged 1 commit intodevelopfrom
task/15193-dark-mode
Feb 5, 2021
Merged

Jetpack Section: Scan dark mode support#15809
emilylaguna merged 1 commit intodevelopfrom
task/15193-dark-mode

Conversation

@emilylaguna
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna commented Feb 5, 2021 •
edited
Loading

Project #15193

Fixes some dark mode issues.

Screenshots

Light Dark
Simulator Screen Shot - iPhone 11 Pro - 2021-02-05 at 09 33 55 Simulator Screen Shot - iPhone 11 Pro - 2021-02-05 at 09 33 53

To test:

  1. Launch the app
  2. Select My Site
  3. Tap on a site with Jetpack Scan enabled
  4. Tap on Scan
  5. Tap on a threat to view the details
  6. Check the code context in light and dark modes

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@emilylaguna emilylaguna added this to the 16.7 milestone Feb 5, 2021
@emilylaguna emilylaguna self-assigned this Feb 5, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 5, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 5, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@emilylaguna emilylaguna merged commit 69c071b into develop Feb 5, 2021
@emilylaguna emilylaguna deleted the task/15193-dark-mode branch February 5, 2021 15:25
@emilylaguna emilylaguna mentioned this pull request Feb 5, 2021
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

Assignees

@emilylaguna emilylaguna

Labels

Jetpack Mobile [Type] Task

Projects

None yet

Milestone

16.7

Development

Successfully merging this pull request may close these issues.

2 participants

@emilylaguna @leandroalonso