Skip to content

Jetpack Section: Fix iPad issues#15798

Merged
emilylaguna merged 4 commits intodevelopfrom
task/15193-ipad-support
Feb 5, 2021
Merged

Jetpack Section: Fix iPad issues#15798
emilylaguna merged 4 commits intodevelopfrom
task/15193-ipad-support

Conversation

@emilylaguna
Copy link
Copy Markdown
Contributor

Project: #15193

To test:

Backup menu crash

  1. Launch the app
  2. Tap on My Site
  3. Tap on Backup or Activity Log
  4. Tap on the ... menu
  5. The alert should be presented and the app should not crash

Share Menu Issue

  1. Launch the app
  2. Tap on My Site
  3. Tap on Backup or Activity Log
  4. Tap on Download backup
  5. Create a downloadable backup, and wait
  6. On the final view tap on Share Link
  7. The share dialog should be displayed and not clipped

Scan status clipping

  1. Launch the app
  2. Tap on My Site
  3. Tap on Scan
  4. The scan status buttons should not be clipped

Don't allow selection on threats being fixed

  1. Launch the app
  2. Tap on My Site
  3. Tap on Scan
  4. Fix a threat
  5. You should not be able to select the threat that is being fixed

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@emilylaguna emilylaguna merged commit e65eee9 into develop Feb 5, 2021
@emilylaguna emilylaguna deleted the task/15193-ipad-support branch February 5, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants