Skip to content

Jetpack Section: add tracking for Jetpack Scan events#15788

Merged
emilylaguna merged 3 commits intodevelopfrom
task/15190-scan-tracks
Feb 4, 2021
Merged

Jetpack Section: add tracking for Jetpack Scan events#15788
emilylaguna merged 3 commits intodevelopfrom
task/15190-scan-tracks

Conversation

@momo-ozawa
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa commented Feb 4, 2021 •
edited
Loading

Part of #15190

Description:

  • Added tracking for Jetpack Scan events 👀

To test:

Verify that the following actions fire the correct event with the correct properties.

Please refer to the event tracking spreadsheet for more details about the event name / event properties.

Action Event
Open the scan screen jetpack_scan_accessed
Tap the history button jetpack_scan_history_accessed
Switch tabs on the scan history screen jetpack_scan_history_filter
Go back to scan screen and tap on scan now jetpack_scan_run_tapped
Tap on a threat jetpack_scan_threat_list_item_tapped
Tap on ignore threat jetpack_scan_ignorethreat_dialogopen
Confirm ignore on alert dialog jetpack_scan_threat_ignore_tapped
Tap on a threat then tap on fix threat jetpack_scan_fixthreat_dialogopen
Confirm fix on alert dialog jetpack_scan_threat_fix_tapped
Tap on fix all in scan screen jetpack_scan_allthreats_open
Tap on contact support in scan screen (scan error) jetpack_scan_error_contact_tapped

Errors

Error Event
Scan error (turn wifi off mid process) jetpack_scan_error
Ignore error (turn wifi off mid process) jetpack_scan_error
Fetch scan history error (turn wifi off mid process) jetpack_scan_error

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@momo-ozawa momo-ozawa added this to the 16.7 milestone Feb 4, 2021
@momo-ozawa momo-ozawa self-assigned this Feb 4, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 4, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 4, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@momo-ozawa
Copy link
Copy Markdown
Contributor Author

momo-ozawa commented Feb 4, 2021

@emilylaguna 👋
I left a couple of Scan events to be added later, since I wanted to wait until your current PRs are merged.

emilylaguna
emilylaguna approved these changes Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll add the missing events in a new PR.

@emilylaguna emilylaguna merged commit 1ee3e6e into develop Feb 4, 2021
@emilylaguna emilylaguna deleted the task/15190-scan-tracks branch February 4, 2021 17:24
@emilylaguna emilylaguna mentioned this pull request Feb 5, 2021
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso Awaiting requested review from leandroalonso

1 more reviewer

@emilylaguna emilylaguna emilylaguna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@momo-ozawa momo-ozawa

Labels

Jetpack Mobile [Type] Task

Projects

None yet

Milestone

16.7

Development

Successfully merging this pull request may close these issues.

2 participants

@momo-ozawa @emilylaguna